Do not render sidebar over menu dialog windows - #68
Open
tinix0 wants to merge 1 commit into
Open
Conversation
|
Development builds of e5fea1c: The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flip rendering order of sidebar and dialog windows when handling WM_PAINT to not overdraw the dialog. The sidebar painting is needed in this place to prevent rendering artifacts when changing between different menu dialogs. While the game is running the rendering of sidebar is handled elsewhere.
Behavior and compatibility
Bug fix to restore original behaviour and remove graphical artifacts.
Validation
Manual testing in GDI1 and skirmish mode.
Documentation
N/A, small visual change to restore original behaviour.
Checklist